Refactor thread pool configuration #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakn7
reviewed
Sep 30, 2024
docs/server_configuration.rst
Outdated
| - Name prefix for threads created by metrics threadpool executor | ||
| - MetricsExecutor | ||
|
|
||
| * - vector_merge.maxThreads |
There was a problem hiding this comment.
Our configs are all in camel case, should this be camel case as well? We can also just call the ExecutorType VECTORMERGE to make this easier.
| @@ -323,7 +324,11 @@ private void fetchFields(SearchContext searchContext) | |||
| hitBuilders.sort(Comparator.comparing(Hit.Builder::getLuceneDocId)); | |||
|
|
|||
| IndexState indexState = searchContext.getIndexState(); | |||
| int fetch_thread_pool_size = indexState.getThreadPoolConfiguration().getMaxFetchThreads(); | |||
| int fetch_thread_pool_size = | |||
There was a problem hiding this comment.
Nit: should we update these variable names and make them camel case?
sarthakn7
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the thread pool settings to have a standardized structure. This should make it more straightforward to add new pools or settings.
Thread pool settings are now grouped by type:
When
<pool_name>is one of: search, index, luceneserver, replicationserver, fetch, grpc, metrics, vector_merge.Settings:
maxThreads- max threads for the thread poolmaxBufferedItems- max tasks to queuethreadNamePrefix- prefix to add to thread names